Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds OpenBao support to the vault-mgmt project by introducing a Flavor enum that allows the tool to work with both Vault and OpenBao instances. The refactoring generalizes the codebase to support multiple vault-like implementations while maintaining backward compatibility with existing Vault installations.
Key changes:
- Added a
Flavorenum to distinguish between OpenBao and Vault - Refactored test structure to use common modules for both flavors
- Updated all label references from hardcoded
vault-*to flavor-specific labels
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/show.rs | Removed old e2e test file (being replaced by common modules) |
| tests/e2e/main.rs | Removed old e2e module structure |
| tests/common/values-openbao.yaml | Added OpenBao Helm chart configuration |
| tests/common/upgrade.rs | Converted tests to reusable functions with flavor support |
| tests/common/show.rs | Converted show test to reusable function |
| tests/common/setup.rs | Updated setup to support both flavors |
| tests/common/prepare.rs | Added debug logging and flavor-specific labels |
| tests/common/mod.rs | New module structure for common test code |
| tests/common/helm.rs | Updated to support OpenBao helm repository |
| tests/02-vault.rs | New Vault-specific test file |
| tests/01-openbao.rs | New OpenBao-specific test file |
| tests/00-setup.rs | Basic setup tests |
| src/wait.rs | Updated condition functions to use flavor parameter |
| src/upgrade.rs | Updated upgrade logic to use flavor-aware functions |
| src/unseal.rs | Updated to use flavor-specific pod selection |
| src/show.rs | Updated table construction to use flavor-specific labels |
| src/main.rs | Added flavor CLI parameter and updated function calls |
| src/lib.rs | Minor import reorganization |
| src/init.rs | Added flavor parameter to initialization functions |
| src/helpers.rs | Added Flavor enum and updated helper functions |
| src/exec.rs | Updated exec functionality to use flavor-specific labels |
| Cargo.toml | Version bump to 0.1.6 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tobikris
force-pushed
the
openbao-support
branch
2 times, most recently
from
10e35d0 to
5818a0e
Compare
tobikris
force-pushed
the
openbao-support
branch
from
5818a0e to
e879464
Compare
lu1as
approved these changes
Aug 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.